Skip to content

[Bug Fix] Fix the element size calculation in AeroAcoustics module#3133

Merged
andrew-platt merged 3 commits intoOpenFAST:devfrom
bjonkman:b/AA_elementSize
Jan 16, 2026
Merged

[Bug Fix] Fix the element size calculation in AeroAcoustics module#3133
andrew-platt merged 3 commits intoOpenFAST:devfrom
bjonkman:b/AA_elementSize

Conversation

@bjonkman
Copy link
Contributor

@bjonkman bjonkman commented Jan 8, 2026

Feature or improvement description
On last node (at the tip), the element size for aeroacoustics calculations was calculated as half the difference in span locations between the last two nodes. This should not be divided by 2.

Related issue, if one exists

Impacted areas of the software
AeroAcoustics only

Test results, if applicable
The AeroAcoustics regression test, IEA_LB_RWT-AeroAcoustics fails. Here are some of the failing channels:

image image image image

On last node, the element size was calculated as half the distance in span between the last two nodes. This should not be divided by 2.
@andrew-platt andrew-platt self-assigned this Jan 9, 2026
@andrew-platt andrew-platt added this to the v4.2.0 milestone Jan 9, 2026
@andrew-platt
Copy link
Collaborator

This has a relatively large impact on the measurements forObs1. I'm not familiar enough with this to know if this is an important change or not. @ptrbortolotti, can you give your thoughts on this? Does this better reflect real world data, or is this within the uncertainty of measurements?

@andrew-platt
Copy link
Collaborator

andrew-platt commented Jan 13, 2026

  • update r-test results before merge

@andrew-platt andrew-platt merged commit f9f1986 into OpenFAST:dev Jan 16, 2026
23 of 24 checks passed
@bjonkman bjonkman deleted the b/AA_elementSize branch January 19, 2026 18:48
@andrew-platt andrew-platt mentioned this pull request Jan 23, 2026
36 tasks
@ptrbortolotti
Copy link
Contributor

hi @bjonkman and @andrew-platt. thank you for your patience. I've finally had the time to run some checks, rerunning the Case 1.1 from this this conference paper, see Figure 7, and this technical report, see Figure 41.

The summary is that this PR changes the results minimally.

These are the results from the conference paper. I generated those in 2021 running OpenFAST v3.0.0 (or possibly a dev branch around that time)
Screenshot 2026-01-29 at 1 55 09 PM

This is the comparison today between v3.0.0, v4.1.2, and v4.2.0. The first two match exactly, the second is slightly different

comparison_spectra

Please let me know if you'd like to see more checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants